Skip to content

Refactor api handler and introduce service layer #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Mar 4, 2023
Merged

Refactor api handler and introduce service layer #5239

merged 60 commits into from
Mar 4, 2023

Conversation

@pranavxc
Copy link
Member

@pranavxc pranavxc commented Mar 2, 2023 •
edited
Loading

Change Summary

  • Split our current api handlers into Controller and service, all the logic goes to service.
  • Move AJV validation from express middleware to service

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

pranavxc added 30 commits March 2, 2023 23:47
@pranavxc
refactor: move api handlers to controllers folder
00c942f 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: rename controller files
60c08e0 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(wip): controller-service implementation
9c9ceb7 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: handler to service-controller - table and column
60507cc 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refcator: handler to service-controller - project, column, view, hook…
89adb8d 
…, base (WIP)

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refcator: handler to service-controller - form, gallery, grid, kanban…
10195c8 
…, plugin (WIP)

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refcator: handler to service-controller - grid column and view column…
b0d8ee8 
… (WIP)

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refcator: handler to service-controller - metadiff and map view (WIP)
3af09aa 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refcator: handler to service-controller - modelvisibility and verify …
50f8266 
…view belongs to the project

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: sharedBaseApi hander
afd73c0 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: orgUserApi handler
ec0c21b 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: attachment, orguser, orgtoken, appsettings and projectuser
88365ec 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: hook filter api
8ca0095 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: data alias apis api
e9da75f 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: relation data apis and deprecated api
a49704f 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: bulk data apis
8c9b856 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: audit, cache handler and data export api(WIP)
d4d8e8a 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: swagger api
675a95b 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: user api
b3a5b48 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: sync api
ed93917 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: public apis
92d4793 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: map new controller
2e36016 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: type corrections
f7fdedb 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
chore: build sdk
db1a998 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: add missing return statement
0cb2d13 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: typo correction
5a32984 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: api handler order correction
f4c0ce5 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: remove extra object wrapping
1f9d36a 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: handle not null error
9a1970a 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: path param typo correction
4dd5ed2 
Signed-off-by: Pranav C <pranavxc@gmail.com>
pranavxc added 10 commits March 3, 2023 18:41
@pranavxc
refactor: move table update logic to service
76e09b5 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: remove unused import statements
08130e8 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: include missing audit log data
2dec831 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: remove duplicate method
b9cf291 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: remove old file
af488e5 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: move new implementation to public folder
0efe400 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: use service in public api handlers
7a5badc 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: remove public folder
4bb26cd 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: rename public folder name
f8b65c0 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: rename public folder and controller names
b72aed6 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc changed the title Refactor/introduce service layer Refactor api handler and introduce service layer Mar 3, 2023
@pranavxc pranavxc mentioned this pull request Mar 3, 2023
Closed
7 tasks
pranavxc added 3 commits March 4, 2023 01:33
@pranavxc
refactor: add conditional service function logic
ac9596d 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: update data apis
d0da577 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: remove duplicate code
7c11883 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc force-pushed the refactor/introduce-service-layer branch from 4d486f6 to 7c11883 Compare March 4, 2023 05:09
pranavxc added 7 commits March 4, 2023 10:47
@pranavxc
refactor: rename file names
aabeacf 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: move project and table handler
51781ed 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: update project and table handler content
b69bc28 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: rename project and table handler name
7e7ce95 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: remove duplicate handler
eb79f50 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: move nested data(LTAR) apis logic to service
ced48a2 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: rename folders
842819c 
Signed-off-by: Pranav C <pranavxc@gmail.com>
wingkwong
wingkwong reviewed Mar 4, 2023
View reviewed changes
@pranavxc
refactor: suggested changes
c0ad5b1 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc force-pushed the refactor/introduce-service-layer branch from 69dade7 to c0ad5b1 Compare March 4, 2023 09:38
@pranavxc pranavxc marked this pull request as ready for review March 4, 2023 10:49
@pranavxc pranavxc merged commit b515731 into develop Mar 4, 2023
@pranavxc pranavxc deleted the refactor/introduce-service-layer branch March 4, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wingkwong wingkwong wingkwong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. trigger-CI force trigger CI even if PR in draft mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pranavxc @wingkwong