Skip to content

enhancement: validations #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 22, 2023
Merged

enhancement: validations #5328

merged 18 commits into from
Mar 22, 2023

Conversation

@wingkwong
Copy link
Contributor

@wingkwong wingkwong commented Mar 20, 2023 •
edited
Loading

Change Summary

  • Email Validation in Form View (invalid value won't be saved - error message will be shown once blurred)
  • URL Validation in Form View (invalid value won't be saved - error message will be shown once blurred)
  • avoid setting invalid email value in Grid View (similar to URL)
  • fix incorrect required toggle logic in Form View (Playwright)

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@wingkwong wingkwong added the trigger-CI force trigger CI even if PR in draft mode label Mar 20, 2023
@wingkwong wingkwong changed the title enhancement: form validations enhancement: validations Mar 20, 2023
@wingkwong wingkwong removed the trigger-CI force trigger CI even if PR in draft mode label Mar 21, 2023
@wingkwong wingkwong marked this pull request as ready for review March 21, 2023 05:22
@wingkwong wingkwong requested a review from dstala March 21, 2023 05:22
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023 •
edited
Loading

Uffizzi Preview deployment-19685 was deleted.

dstala
dstala requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@dstala dstala left a comment •
edited by wingkwong
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Error message was not displayed in shared form
    Screenshot 2023-03-21 at 12 33 06 PM

Node: v16.14.0
Arch: arm64
Platform: darwin
Docker: false
RootDB: sqlite3
PackageVersion: 0.105.3

@wingkwong wingkwong requested a review from dstala March 22, 2023 03:25
@dstala dstala merged commit bdf256a into develop Mar 22, 2023
@dstala dstala deleted the enhancement/form-validation branch March 22, 2023 16:51
@wingkwong wingkwong added this to the Next Release: 0.106.0 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstala dstala dstala approved these changes

Assignees

@dstala dstala

Labels

None yet

Projects

None yet

Milestone

Next Release: 0.106.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wingkwong @dstala