fix (dbConfig): ssl connection with file path is not handled correctly #5364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Let's say I have postgres server that only accepts ssl connection. But the cert on the server is self-signed. For this, I need to provide ca cert to nocodb. This is my command on packages/nocodb:
NC_DB="pg://ssldbhost:5400?u=theuser&p=thepass&d=nocodb&connection.ssl.caFilePath=/config/ca.crt" npm run runI will get
SELF_SIGNED_CERT_IN_CHAIN. This is because thepromisifyreturns aPromiseand the returned promise is converted bytoString()first before it's resolved. AnddbConfig.connection.ssl.canow has[object Promise]as value.Change type
Test/ Verification
Run the command from the
Change Summaryagain. It should gives usApp started successfully..Additional information / screenshots (optional)
dbConfig.connection.ssl.caFilePathis an extra parameter for pg connection, and somehow here it must be removed or it won't work.fs.readFileSync, but I don't use it, to keep the original approach.