Skip to content

fix(nocodb): incorrect public path for docker #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 24, 2023
Merged

fix(nocodb): incorrect public path for docker #5721

merged 8 commits into from
May 24, 2023

Conversation

@wingkwong
Copy link
Contributor

@wingkwong wingkwong commented May 24, 2023 •
edited
Loading

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@wingkwong wingkwong added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label May 24, 2023
@wingkwong wingkwong mentioned this pull request May 24, 2023
Closed
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023 •
edited
Loading

Uffizzi Preview deployment-26431 was deleted.

@wingkwong wingkwong requested a review from pranavxc May 24, 2023 10:38
@wingkwong wingkwong removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label May 24, 2023
pranavxc
pranavxc reviewed May 24, 2023
View reviewed changes
pranavxc
pranavxc approved these changes May 24, 2023
View reviewed changes
pranavxc
pranavxc reviewed May 24, 2023
View reviewed changes
Copy link
Member

@pranavxc pranavxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it from here as well

nocodb/packages/nocodb/src/app.module.ts

Line 62 in edeae9b

.apply(PublicMiddleware)

@wingkwong wingkwong merged commit 99bce0b into develop May 24, 2023
@wingkwong wingkwong deleted the fix/static-public branch May 24, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranavxc pranavxc pranavxc approved these changes

Assignees

@pranavxc pranavxc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wingkwong @pranavxc