Skip to content

fix(nocodb): attachment original name #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(nocodb): attachment original name #6824

merged 2 commits into from
Oct 30, 2023

Conversation

@wingkwong
Copy link
Contributor

@wingkwong wingkwong commented Oct 29, 2023

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

image

@wingkwong wingkwong requested a review from dstala October 29, 2023 15:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023 •
edited
Loading

Uffizzi Preview deployment-39721 was deleted.

@dstala dstala merged commit 80a20a1 into develop Oct 30, 2023
@dstala dstala deleted the fix/attachment-original-name branch October 30, 2023 04:55
@dstala dstala mentioned this pull request Oct 30, 2023
Closed
1 task
@wingkwong wingkwong mentioned this pull request Oct 30, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstala dstala dstala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Attachment-type data's title string doesn't match non-Ascii char

3 participants

@wingkwong @dstala