Skip to content

fix: vue warnings #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Nov 20, 2023
Merged

fix: vue warnings #6954

merged 31 commits into from
Nov 20, 2023

Conversation

@wingkwong
Copy link
Contributor

@wingkwong wingkwong commented Nov 11, 2023 •
edited
Loading

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@wingkwong wingkwong marked this pull request as ready for review November 11, 2023 16:22
@wingkwong wingkwong requested a review from pranavxc November 11, 2023 16:23
@wingkwong wingkwong marked this pull request as draft November 12, 2023 07:28
@wingkwong wingkwong force-pushed the fix/runtime-directive-warnings branch from efe30d2 to fc56908 Compare November 12, 2023 08:31
@wingkwong wingkwong removed the request for review from pranavxc November 12, 2023 15:10
@wingkwong wingkwong added the trigger-CI force trigger CI even if PR in draft mode label Nov 13, 2023
@wingkwong wingkwong changed the title fix: runtime directive warnings fix: vue warnings Nov 13, 2023
@wingkwong wingkwong marked this pull request as ready for review November 15, 2023 05:57
@wingkwong wingkwong requested a review from pranavxc November 15, 2023 05:57
@wingkwong wingkwong removed the trigger-CI force trigger CI even if PR in draft mode label Nov 15, 2023
@wingkwong wingkwong added 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. and removed 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. labels Nov 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

Uffizzi Preview deployment-40771 was deleted.

@wingkwong wingkwong merged commit a562540 into develop Nov 20, 2023
@wingkwong wingkwong deleted the fix/runtime-directive-warnings branch November 20, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranavxc pranavxc pranavxc approved these changes

Assignees

@pranavxc pranavxc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Runtime directive used on component with non-element root node. The directives will not function as intended.

3 participants

@wingkwong @pranavxc