Skip to content

Conversation

@pranavxc
Copy link
Member

@pranavxc pranavxc commented Jan 16, 2024

Change Summary

  • Instead of 403 return 401 when token invalid
  • Avoid overriding existing additional roles props when loading user info using refresh token

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc pranavxc requested a review from mertmit January 16, 2024 20:25
@o1lab o1lab force-pushed the nc-fix/refresh-token-issue branch from 21b53fb to 45b7c92 Compare January 16, 2024 20:26
@o1lab o1lab force-pushed the nc-fix/refresh-token-issue branch from 45b7c92 to 24081f0 Compare January 17, 2024 06:14
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024

Uffizzi Preview deployment-44481 was deleted.

@pranavxc pranavxc merged commit 866a21c into develop Jan 17, 2024
@pranavxc pranavxc deleted the nc-fix/refresh-token-issue branch January 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants