feat: move button trigger to workers

[DarkPhoenix2704]

Change Summary

Move button triggers to workers

Change type

• feat: (new feature for the user, not a new feature for build script)

[coderabbitai]

Walkthrough

Walkthrough

The changes enhance the HooksService class by integrating a jobsService for asynchronous job processing of webhooks. This shift from immediate invocation to queuing improves reliability and decouples webhook handling. The method for invoking webhooks has been updated to use jobsService.add() with streamlined parameters, reflecting a more efficient and robust approach to handling webhook events.

Changes

File Path	Change Summary
packages/nocodb/src/services/hooks.service.ts	Constructor updated to inject jobsService. The webhook invocation method now queues jobs with updated parameters, improving asynchronous processing of webhook events.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant HooksService
    participant JobsService

    Client->>HooksService: Trigger webhook
    HooksService->>JobsService: Add job (HandleWebhook, parameters)
    JobsService-->>HooksService: Job queued confirmation
    HooksService-->>Client: Webhook processed response

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 44ef0dc and dc717e0.

Files selected for processing (1)

• packages/nocodb/src/services/hooks.service.ts (3 hunks)

Additional comments not posted (3)

packages/nocodb/src/services/hooks.service.ts (3)

16-17: Imports for job processing are appropriate.

The added imports JobTypes and IJobsService are necessary for the job processing functionality.

---

24-24: Constructor injection of jobsService is correct.

The use of @Inject to add jobsService is correctly implemented for dependency injection.

---

181-187: Transition to job-based webhook handling is well-implemented.

The hookTrigger method now queues a job for handling the webhook, which enhances scalability and decouples the operation from immediate execution.

Ensure that the jobsService.add method is implemented correctly to handle the new payload structure.