ColumnFilter ToolBar Correctly Show I18n string and LanguageAlias for zh_Hans

[armgong]

Change Summary

patch #9574 ColumnFilter ToolBar Correctly Show I18n string
LanguageAlias for zh_Hans

Change type

• fix: (bug fix for the user, not a fix to a build script)

Test/ Verification

this is a minor patch, tested on windows, ColumnFilter Correctly Show I18n "and"/"or" string.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces changes to the ColumnFilter.vue component, enhancing the handling of logical operations and filter conditions. Key updates include changing the displayed text for logical operations, refining the logic for displaying filter inputs, and updating the filterUpdateCondition function for better comparison checks. Additionally, modifications to the addFilter and addFilterGroup methods improve scrolling behavior when adding filters. A minor change in the LanguageAlias enum updates the key for simplified Chinese to align with standard ISO naming conventions.

Changes

File	Change Summary
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue	- Updated logical operation display from op.value to op.text. - Refined showFilterInput logic. - Enhanced filterUpdateCondition for comprehensive checks. - Modified addFilter and addFilterGroup for improved scrolling behavior.
packages/nc-gui/lib/enums.ts	- Changed key for simplified Chinese from zn_CN to zh_CN in LanguageAlias enum.

Possibly related PRs

• Nc fix/shared view filter #8837: This PR modifies the ColumnFilter.vue file, which is directly related to the main PR's changes in the same component, focusing on filter logic and computations.

Suggested reviewers

• dstala
• pranavxc

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 97a39f3 and 9682b55.

📒 Files selected for processing (2)

• packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (2 hunks)
• packages/nc-gui/lib/enums.ts (1 hunks)

🔇 Additional comments (3)

packages/nc-gui/lib/enums.ts (1)

42-42: Correct fix for Chinese language code

The change from zn_CN to zh_CN is correct and aligns with ISO 639-1 language codes. This fix should resolve the issue with the ColumnFilter ToolBar not showing correct I18n strings for Chinese (Simplified).

Please run the following script to check for any other occurrences of zn_CN that might need to be updated:

Note: There's a slight inconsistency between the Language enum (which uses 'zh-Hans' as a key) and LanguageAlias (which uses it as a value). This might be intentional, but it's worth noting for future refactoring if needed.

✅ Verification successful

Verification Successful: No Remaining 'zn_CN' References Found

All instances of zn_CN have been updated to zh_CN. No further action is required.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for 'zn_CN' in all files
rg 'zn_CN' --type-not sql

Length of output: 25

packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (2)

670-670: Use of op.text ensures correct I18n display

Changing {{ op.value }} to {{ op.text }} correctly displays the localized text for logical operators, ensuring that internationalization strings are shown appropriately.

---

722-722: Use of op.text ensures correct I18n display

Updating this line to use {{ op.text }} ensures that the logical operator's display text is correctly localized, aligning with the PR's objective to fix I18n string display.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[CLAassistant]

All committers have signed the CLA.