fix(nc-gui): UI Error on toggle locked view

[rameshmane7218]

Change Summary

• ref: 🐛 Bug: NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node. #9713

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request involve documentation updates and modifications to the rendering logic of the NcMenuItem component in two Vue files: MenuItem.vue and ViewActionMenu.vue. In MenuItem.vue, a comment is added to explain a known issue with using v-if without v-else. In ViewActionMenu.vue, the v-if directive is replaced with v-show to prevent a NotFoundError during dynamic state changes. Both changes aim to improve the handling of conditional rendering without altering existing logic.

Changes

File Path	Change Summary
packages/nc-gui/components/nc/MenuItem.vue	Added documentation comment regarding the use of v-if and potential NotFoundError.
packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue	Changed v-if to v-show for NcMenuItem to prevent NotFoundError and added a comment explaining the change.

Possibly related PRs

• Nc fix/miscellaneous #9447: This PR modifies the rendering logic of the NcMenuItem component in ViewActionMenu.vue by changing v-if to v-show, similar to the documentation change in MenuItem.vue that advises using v-show to prevent NotFoundError.
• fix(nc-gui): show mfe save changes field error #9535: This PR introduces changes to the Fields.vue component, which includes error handling and visibility logic, potentially related to the conditional rendering issues discussed in the main PR.
• fix(nc-gui): allow user to submit form in locked view #9705: This PR modifies the Form.vue component's submission logic, which may relate to the overall handling of component states and visibility, similar to the concerns raised in the main PR regarding conditional rendering.

Suggested labels

🐛 Type: Bug, 👓 Scope : View, size:XS, lgtm

Suggested reviewers

• dstala
• mertmit

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6f9ca7a and 5a9d58b.

📒 Files selected for processing (2)

• packages/nc-gui/components/nc/MenuItem.vue (1 hunks)
• packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/nc-gui/components/nc/MenuItem.vue

🔇 Additional comments (2)

packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue (2)

131-142: Well-documented explanation of the v-if issue!

The added documentation block clearly explains the known issue with v-if and the rationale for using v-show. This will help future maintainers understand why this specific approach was chosen.

---

Line range hint 195-201: Correct implementation of the v-show fix!

The change from v-if to v-show for the description update menu item aligns with the documented solution and should resolve the NotFoundError during dynamic state changes.

Let's check if there are other similar instances in the file that might benefit from the same fix:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Uffizzi Preview deployment-57603 was deleted.