fix: Handle duplicate column name issue in junction table

[pranavxc]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request primarily involve modifications to the createLTARColumn method within the columns.service.ts file. The updates focus on ensuring unique column names when creating many-to-many relationships by introducing a conditional check that appends a suffix to avoid name collisions. Additionally, minor formatting adjustments were made for improved readability, while error handling mechanisms remain unchanged.

Changes

File Path	Change Summary
packages/nocodb/src/services/columns.service.ts	Updated createLTARColumn method to include logic for unique column names in many-to-many relationships; minor formatting adjustments made.

Possibly related PRs

• fix: self link duplicate issues #8535: Addresses self-link duplicate issues related to unique column names.
• Nc fix: rename id column if exist in import table #8984: Focuses on renaming ID columns to ensure uniqueness, aligning with the main PR's goals.
• fix: Apply view based filter if linkColumnId present in list api #9500: Introduces logic for handling linkColumnId, connecting to column name management.
• Nc fix/meta sync issue(cloud) #9664: Related to metadata synchronization, indirectly affecting column handling.
• fix: Grid view expanded form next and prev button bug #9718: Addresses a grid view bug related to primary keys, relevant to unique column name management.

Suggested labels

🐛 Type: Bug, lgtm

Suggested reviewers

• mertmit

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e234492 and f58f82f.

📒 Files selected for processing (1)

• packages/nocodb/src/services/columns.service.ts (2 hunks)

🔇 Additional comments (1)

packages/nocodb/src/services/columns.service.ts (1)

152-155: LGTM: Junction table name generation logic is robust and follows best practices.

The code properly handles table name length limits and includes necessary prefixes for clear identification of junction tables.

[github-actions]

Uffizzi Preview deployment-57762 was deleted.