fix: bulkupsert endpoint

[DarkPhoenix2704]

Change Summary

Do not update the created_by and created_at column on update records in bulkUpsert

Change type

• fix: (bug fix for the user, not a fix to a build script)

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request primarily focus on enhancing the BaseModelSqlv2 class within the BaseModelSqlv2.ts file. Key modifications include the introduction of error handling and validation logic in the bulkInsert, bulkUpdate, and bulkDelete methods. The updates improve checks for primary keys, foreign key handling, and data validation for user and attachment fields, thereby enhancing data integrity and transaction management.

Changes

File Path	Change Summary
packages/nocodb/src/db/BaseModelSqlv2.ts	- Enhanced error handling and validation in bulkInsert, bulkUpdate, and bulkDelete methods. - Updated method signatures for bulkInsert, bulkUpdate, bulkDelete, and prepareNocoData to include additional parameters and improve validation.

Possibly related PRs

• fix: Post update extract new id since composite key can be changed in update #9453: Modifies the handling of primary key values during updates in the BaseModelSqlv2 class, related to the main PR's enhancements for primary key handling.
• fix: One-to-one excluded list filter bug #9903: Introduces error handling and validation improvements in methods like insert, updateByPk, and delByPk, aligning with the main PR's focus on similar enhancements in bulk operations.

Suggested labels

🍰 Scope : Column, size:M, lgtm

Suggested reviewers

• mertmit

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/nocodb/src/db/BaseModelSqlv2.ts (1)

Line range hint 7760-7763: Consider initializing 'LastModifiedTime' and 'LastModifiedBy' on insert

Currently, when isInsertData is true, LastModifiedTime and LastModifiedBy are set to null. It might be more appropriate to set them to the current time and user upon insertion to accurately reflect the record's initial state.

Apply the following changes:

- if (column.uidt === UITypes.LastModifiedTime) {
-   data[column.column_name] = isInsertData ? null : this.now();
- } else if (column.uidt === UITypes.LastModifiedBy) {
-   data[column.column_name] = isInsertData ? null : cookie?.user?.id;
- }
+ if (column.uidt === UITypes.LastModifiedTime) {
+   data[column.column_name] = this.now();
+ } else if (column.uidt === UITypes.LastModifiedBy) {
+   data[column.column_name] = cookie?.user?.id;
+ }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4effc44 and 5f7f112.

📒 Files selected for processing (1)

• packages/nocodb/src/db/BaseModelSqlv2.ts (2 hunks)

🔇 Additional comments (3)

packages/nocodb/src/db/BaseModelSqlv2.ts (3)

5339-5341: Data preparation before insertion of new records

Ensures that prepareNocoData is called for records without primary keys before insertion, which initializes necessary system fields.

---

5359-5361: Data preparation before updating existing records

Ensures that prepareNocoData is called for existing records before updating, correctly handling system fields.

---

5362-5364: Data preparation for new records identified during bulkUpsert

Appropriately calls prepareNocoData for new records discovered during bulkUpsert, ensuring system fields are initialized.