Small change to do https #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this wasn't working in node 0.2.5 or 0.2.6. Without the secure flag, node will attempts to open the socket and perform the http get without first performing an SSL handshake.
|
Hey thanks, but I've purposely stayed away from HTTPS for the time being as the NodeJS API is constantly changing. The latest unstable release introduces a new dedicated https module |
|
Now that 0.4.x is out, is there a chance we might get to see this soon? Some of the pages I am scraping do automatic HTTPS redirects. :-( |
|
Done! |
|
Wow, that was fast! Thanks!! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the commit message:
Small change to do Https. Not sure when the secure flag was added, but
this wasn't working in node 0.2.5 or 0.2.6. Without the secure flag,
node will attempt to open the socket and perform the http get without
first performing an SSL handshake.