Skip to content

Conversation

@HiroyasuNishiyama
Copy link
Member

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This PR adds experimental support of Node-RED dashboard node generation.
See README.md for details.

Checklist

Put an x in the boxes that apply

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage increased (+0.2%) to 73.487% when pulling 21ae0e7 on node-red-hitachi:widget-template into 504a4c0 on node-red:master.

@@ -0,0 +1,208 @@
This node is under Apache-2.0 licence because it was created from the following
fuction node code using [node-red-nodegen](https://github.com/node-red/node-red-nodegen).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HiroyasuNishiyama This description is for function node template. Please replace "function node" and URLs with node-red-dashboard template node's one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazuhitoyokoi thank you for pointing it. fixed description in LICENSE.mustache file.

@kazuhitoyokoi kazuhitoyokoi merged commit 321f760 into node-red:master Feb 13, 2018
@kazuhitoyokoi
Copy link
Member

@HiroyasuNishiyama
Thank you for this. I have another request. Could you update the help in command line as another pull request? I hope that it's same as README.md.
https://github.com/node-red/node-red-nodegen/blob/master/bin/node-red-nodegen.js#L41-L78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants