Skip to content

Conversation

@kazuhitoyokoi
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

The node generated by Swagger template throws an error when the node refers to the undefined variables. To fix the problem, I added conditions to check the values.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@HiroyasuNishiyama HiroyasuNishiyama merged commit f5729a2 into node-red:master Feb 15, 2018
@kazuhitoyokoi
Copy link
Member Author

@HiroyasuNishiyama Thank you!

@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 73.487% when pulling 73e736e on kazuhitoyokoi:master into 321f760 on node-red:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.487% when pulling 73e736e on kazuhitoyokoi:master into 321f760 on node-red:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants