-
Notifications
You must be signed in to change notification settings - Fork 55
enable override of node properties and clean up codegen template #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable override of node properties and clean up codegen template #20
Conversation
|
[slight off-topic]: Any idea why my identation on the commit seems messed up? |
|
Probably you have to use spaces instead of tab as indentation. |
|
We don’t do mustache templating in general - and I am not in favour of adding it here. But if you just want to set a node property to the value of a msg property, then we’d normally now use a TypedInput that lets you pick a |
|
I updated the PR according to the recommendation from @knolleary (i.e changed param fields to typedInput) + added more helpers for code generation |
|
@t-ide Thank you for your help. @HiroyasuNishiyama Could you merge this pull request? |
|
I had to amend the PR because the naive way of retrieving msg property was not working for deep/nested properties (ex. msg.a.b.c). |
|
@HiroyasuNishiyama Thank you. 👍 |

Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyProposed changes
This change enables to externaly override node properties (i.e. on the incoming msg).
It also allows for mustache templating on the node property (i.e. use {{attribute}} in the node UI to explicitly reference a msg attribute).
I also cleaned up the code generation template in case of 'body' parameter, to reduce code clutter and make the generated code a bit more intuitive for human reading.
Checklist
Put an
xin the boxes that applygruntto verify the unit tests pass