Fix snmp community default issue #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can be defined by the msg. Error will be thrown if you try to override what was defined in the node. Verified that the contents of msg is no longer clobbered. Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
fixed documentation as noted, removed conflict and iff from documention remove node.warns if host or community are set in both the node config and msg Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
This commit uses a singleton aproach to create socket. It still needs to be tested to see if there is any issue to the never-close, but reuse socket model. My only concern is if a socket dies, do we need to do something to reestablish it? Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
attribute in the snmp node. This was preventing a user from being able to set the community value within the msg. Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Member
|
so now it won't work by default ? - should leave the default value... - users should remove it if they then want to override. |
2 similar comments
Contributor
Author
|
It should still work by default. We set var community = node.community || msg.community;which gets thrown into which creates a var Session = function (target, community, options) {
this.target = target || "127.0.0.1";
this.community = community || "public";
...If we want to, for clarity's sake, still have |
Member
|
Agree with your last comment. I like clarity. |
…them to be set so that they can be set my msg.host and msg.community respectivly. Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed default value and required attribute from the community field in the snmp node.
This was preventing a user from being able to set the community value within the msg.
This issue was noticed in #311.