io/emoncms - Modify HTTP Timeout #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the HTTP Timeout values from 1000 to 6000. Modify error message.
dceejay
reviewed
Apr 10, 2018
io/emoncms/88-emoncms.js
Outdated
| request.setTimeout(1000, function() { | ||
| node.error("timeout: " + msg); | ||
| request.setTimeout(6000, function() { | ||
| node.error(msg); |
Member
There was a problem hiding this comment.
Actually the node.error ought to take two parameters, the text to show in the debug panel and the msg that caused the problem. so node.error("HTTP Timeout",msg);
Contributor
Author
There was a problem hiding this comment.
Ok great. Everyday a learning day...
Contributor
Author
|
@dceejay - Done. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #429
Modify timeout value from 1000 to 6000
Modify error message.