Refactoring credentials into foursquare-credentials #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
added a commit
that referenced
this pull request
Oct 22, 2014
[wip] Refactoring credentials into foursquare-credentials
hbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the credentials side of the swarm node out into its own node (#41).
Note I've also changed the colour of the node to be orange (to fit with the swarm colouring) and added the "m=swarm" parameter on the end of the API request as part of this pull request.
@knolleary - although I've marked this pull request as [wip] it's all ready to go once pull request node-red/node-red#449 has been merged. The failing tests which appear against this refactoring pull request will be fixed when the changes are made to the main node-red test helper.