Simple pinboard tests and minor fix #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
added a commit
that referenced
this pull request
Nov 27, 2014
Simple pinboard tests and minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the pinboard node is similar to the delicious one. Therefore added a couple of the basic "if this property isn't set" type tests along with adding the missing "return" statement in the node itself in the same way as with the delicious node.
Still more tests that can be done here. Ones that use "nock" to mock the calls but they can be added as and when (just copy the delicious ones). Plus I don't have a pinboard account which can be used to find the api calls and results to mock.