Skip to content

Conversation

@vemonet
Copy link
Contributor

@vemonet vemonet commented Sep 3, 2020

Remove outdated instructions about running using Docker from README.md, and redirect the user to the docker-images/README documentation page

…d, and redirect the user to the docker-images/README documentation page
@bourgeoa
Copy link
Member

bourgeoa commented Sep 4, 2020

There are 2 ways to use docker :

  • with the docker-image using some env parameters
  • using the Dockerfile and a config.json with extensive parameters

I personally only use the Dockerfile which can also be used to test NSS modifications.

The documentation should reflect that, and not only the docker-image way.

@angelo-v
Copy link
Contributor

angelo-v commented Sep 4, 2020

You could mount a config.json to the production image as well. The dockerfile is good for development while the image is production ready.

We should not recommend to use the dockerfile in the readme

@bourgeoa
Copy link
Member

bourgeoa commented Sep 4, 2020

I don't think the documentation relates only to production ready server. That's why both approach should be maintained.

@angelo-v
Copy link
Contributor

angelo-v commented Sep 4, 2020

You are right @bourgeoa the readme currently mixes both and we should reflect that for docker as well, just separate both variants clearly by subsections.

vemonet and others added 2 commits September 5, 2020 14:23
Add headline to deploy with Docker for Production usage

Co-authored-by: Angelo Veltens <angelo.veltens@online.de>
…th instructions to build and run solid using the Dockerfile at the root of the repository
@vemonet
Copy link
Contributor Author

vemonet commented Sep 5, 2020

Thanks for the feedback @angelo-v

@bourgeoa I put back the previous documentation describing the use of the Dockerfile at the root of the repository under the Development usage section

@bourgeoa
Copy link
Member

bourgeoa commented Sep 8, 2020

OK for me

@bourgeoa bourgeoa merged commit 654b95c into nodeSolidServer:master Sep 8, 2020
Copy link
Contributor

@angelo-v angelo-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants