-
Notifications
You must be signed in to change notification settings - Fork 305
Fix Docker instructions in the main README #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d, and redirect the user to the docker-images/README documentation page
|
There are 2 ways to use docker :
I personally only use the Dockerfile which can also be used to test NSS modifications. The documentation should reflect that, and not only the docker-image way. |
|
You could mount a config.json to the production image as well. The dockerfile is good for development while the image is production ready. We should not recommend to use the dockerfile in the readme |
|
I don't think the documentation relates only to production ready server. That's why both approach should be maintained. |
|
You are right @bourgeoa the readme currently mixes both and we should reflect that for docker as well, just separate both variants clearly by subsections. |
Add headline to deploy with Docker for Production usage Co-authored-by: Angelo Veltens <angelo.veltens@online.de>
…th instructions to build and run solid using the Dockerfile at the root of the repository
|
Thanks for the feedback @angelo-v @bourgeoa I put back the previous documentation describing the use of the Dockerfile at the root of the repository under the |
|
OK for me |
angelo-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Remove outdated instructions about running using Docker from README.md, and redirect the user to the docker-images/README documentation page