Check write on container for delete #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Also But may be around https://github.com/solid/node-solid-server/blob/ac596768d3360aeb9f4137e4025b0b478052429b/lib/acl-checker.js#L91 acl-checker was upgraded to be able to check permissions separately on resource and parent. |
Member
Author
|
@bourgeoa please review |
michielbdejong
force-pushed
the
check-write-on-container-for-delete
branch
from
609d6a5 to
8c925c0
Compare
bourgeoa
reviewed
Nov 23, 2021
lib/acl-checker.js
Outdated
Comment on lines
107
to
110
| const accessDeniedAccessTo = aclCheck.accessDenied(acl.graph, directory, null, aclFile, agent, [ACL('Write')], agentOrigin, trustedOrigins, originTrustedModes) | ||
| const accessResult = !accessDenied && !accessDeniedAccessTo | ||
| accessDenied = accessResult ? false : accessDenied || accessDeniedAccessTo | ||
| // debugCache('accessDenied result ' + accessDenied) |
Member
There was a problem hiding this comment.
Why not make a function accessToFromParent (aclValue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See solid-contrib/web-access-control-tests#42
This reverts https://github.com/solid/node-solid-server/pull/1557/files#diff-296d21adeb16979ad974b59ab2cf7fa5be21fb4c898c3d5aab20fbd5081c97f3L29-R29