Implement stopTrackingSession method #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Use |
Contributor
|
Would rename to |
Author
|
@RubenVerborgh Ok it seems to work with |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, it may be desirable to stop tracking session status. This PR implements such a feature.
However, it's important to note that the Flow linter is currently throwing an error, but I'm not sure why. The error in particular is
Cannot call this.off because property off is missing in SolidAuthClient. I'm not familiar with Flow, but I don't understand why is this failing. The off method exists in the parent class EventEmitter, so it should be ok. The test I implemented is also passing, so the implementation should be correct.