Bugfix releasing a key that was pressed over another window (i.e. Shift) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: Open a Nodebox window, go to another X window, press "Shift" key, focus again on the Nodebox window with the mouse and release "Shift" key. Nodebox exits with a ValueError exception because the key is not in the _keys list of pressed keys. Environment: Xubuntu Linux 14.04 (XFCE desktop) Solution: ignore ValueError exceptions when removing keys from the _keys list
fdb
added a commit
that referenced
this pull request
Nov 16, 2015
Bugfix releasing a key that was pressed over another window (i.e. Shift)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Open a Nodebox window, go to another X window, press "Shift" key, focus again on the Nodebox window with the mouse and release "Shift" key. Nodebox exits with a ValueError exception because the key is not in the _keys list of pressed keys.
Environment: Xubuntu Linux 14.04 (XFCE desktop)
Solution: ignore ValueError exceptions when removing keys from the _keys list