Skip to content

Documentation #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 4, 2020
Merged

Documentation #150

merged 6 commits into from
Aug 4, 2020

Conversation

@rob3000
Copy link
Member

@rob3000 rob3000 commented Aug 4, 2020

krystianity
krystianity approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@krystianity krystianity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in sinek pr, not sure if we should switch to npm lock files instead of yarn.
Also we should put the whole docs (or website) subdirectory in the npm ignore path

@rob3000
Copy link
Member Author

rob3000 commented Aug 4, 2020

😅 whoops! will add website to npm ignore.
In regards to npm vs yarn, i don't really mind. i guess we can leave it for this pr and open another issue up for discussion?

@rob3000
Copy link
Member Author

rob3000 commented Aug 4, 2020

reference to discussion on yarn vs node: nodefluent/node-sinek#155

@krystianity krystianity merged commit ff1e527 into nodefluent:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krystianity krystianity krystianity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rob3000 @krystianity