fix: adding dns lookup supported by node 8

Author: rezakrimi

plugins/node/opentelemetry-plugin-dns/test/integrations/dnspromise-lookup.test.ts

@@ -33,13 +33,23 @@ const logger = new NoopLogger();
 const provider = new NodeTracerProvider({ logger });
 provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
 
+async function lookupPromise(hostname:string, options:dns.LookupOptions = {}): Promise<any>{
+  return new Promise((resolve, reject) => {
+      dns.lookup(hostname, options,(err, address, family) => {
+          if(err) reject(err);
+          if (options.all){
+            resolve(address);
+          }
+          else{
+            resolve({ address, family });
+          }
+      });
+ });
+};
+
 describe('dns.promises.lookup()', () => {
   before(function (done) {
-    // skip tests if node version is not supported
-    if (semver.lte(process.versions.node, '10.6.0')) {
-      this.skip();
-    }
-
+    
     // if node version is supported, it's mandatory for CI
     if (process.env.CI) {
       plugin.enable(dns, provider, provider.logger);
@@ -69,9 +79,9 @@ describe('dns.promises.lookup()', () => {
     [4, 6].forEach(ipversion => {
       it(`should export a valid span with "family" arg to ${ipversion}`, async () => {
         const hostname = 'google.com';
-        const { address, family } = await dns.promises.lookup(
+        const {address, family}  = await lookupPromise(
           hostname,
-          ipversion
+          {family:ipversion}
         );
         assert.ok(address);
         assert.ok(family);
@@ -87,7 +97,9 @@ describe('dns.promises.lookup()', () => {
   describe('with no options param', () => {
     it('should export a valid span', async () => {
       const hostname = 'google.com';
-      const { address, family } = await dns.promises.lookup(hostname);
+      const { address, family } = await lookupPromise(
+        hostname
+      );
 
       assert.ok(address);
       assert.ok(family);
@@ -101,7 +113,9 @@ describe('dns.promises.lookup()', () => {
     it('should export a valid span with error NOT_FOUND', async () => {
       const hostname = 'ᚕ';
       try {
-        await dns.promises.lookup(hostname);
+        await lookupPromise(
+          hostname
+        );
         assert.fail();
       } catch (error) {
         const spans = memoryExporter.getFinishedSpans();
@@ -122,52 +136,79 @@ describe('dns.promises.lookup()', () => {
     it('should export a valid span with error INVALID_ARGUMENT when "family" param is equal to -1', async () => {
       const hostname = 'google.com';
       try {
-        await dns.promises.lookup(hostname, -1);
+        await lookupPromise(hostname, {family: -1});
         assert.fail();
       } catch (error) {
         const spans = memoryExporter.getFinishedSpans();
         const [span] = spans;
 
         assert.strictEqual(spans.length, 1);
-        assertSpan(span, {
-          addresses: [],
-          hostname,
-          forceStatus: {
-            code: CanonicalCode.INVALID_ARGUMENT,
-            message: error!.message,
-          },
-        });
+        if (semver.lt(process.versions.node, '9.0.0')) {
+          assertSpan(span, {
+            addresses: [],
+            // tslint:disable-next-line:no-any
+            hostname: hostname as any,
+            forceStatus: {
+              code: CanonicalCode.UNKNOWN,
+              message: error!.message,
+            },
+          });
+        }
+        else{
+          assertSpan(span, {
+            addresses: [],
+            // tslint:disable-next-line:no-any
+            hostname: hostname as any,
+            forceStatus: {
+              code: CanonicalCode.INVALID_ARGUMENT,
+              message: error!.message,
+            },
+          });
+        }
       }
     });
 
     it('should export a valid span with error INVALID_ARGUMENT when "hostname" param is a number', async () => {
       const hostname = 1234;
       try {
         // tslint:disable-next-line:no-any
-        await dns.promises.lookup(hostname as any, 4);
+        await lookupPromise(hostname as any, {family: 4});
         assert.fail();
       } catch (error) {
         const spans = memoryExporter.getFinishedSpans();
         const [span] = spans;
 
         assert.strictEqual(spans.length, 1);
-        assertSpan(span, {
-          addresses: [],
-          // tslint:disable-next-line:no-any
-          hostname: hostname as any,
-          forceStatus: {
-            code: CanonicalCode.INVALID_ARGUMENT,
-            message: error!.message,
-          },
-        });
+        if (semver.lt(process.versions.node, '9.0.0')) {
+          assertSpan(span, {
+            addresses: [],
+            // tslint:disable-next-line:no-any
+            hostname: hostname as any,
+            forceStatus: {
+              code: CanonicalCode.UNKNOWN,
+              message: error!.message,
+            },
+          });
+        }
+        else{
+          assertSpan(span, {
+            addresses: [],
+            // tslint:disable-next-line:no-any
+            hostname: hostname as any,
+            forceStatus: {
+              code: CanonicalCode.INVALID_ARGUMENT,
+              message: error!.message,
+            },
+          });
+        }
       }
     });
   });
   describe('with options param', () => {
     [4, 6].forEach(ipversion => {
       it(`should export a valid span with "family" to ${ipversion}`, async () => {
         const hostname = 'google.com';
-        const { address, family } = await dns.promises.lookup(hostname, {
+        const { address, family } = await lookupPromise(hostname, {
           family: ipversion,
         });
 
@@ -183,7 +224,7 @@ describe('dns.promises.lookup()', () => {
 
       it(`should export a valid span when setting "verbatim" property to true and "family" to ${ipversion}`, async () => {
         const hostname = 'google.com';
-        const { address, family } = await dns.promises.lookup(hostname, {
+        const { address, family } = await lookupPromise(hostname, {
           family: ipversion,
           verbatim: true,
         });
@@ -201,7 +242,7 @@ describe('dns.promises.lookup()', () => {
 
     it('should export a valid span when setting "all" property to true', async () => {
       const hostname = 'montreal.ca';
-      const addresses = await dns.promises.lookup(hostname, { all: true });
+      const addresses = await lookupPromise(hostname, { all: true });
 
       assert.ok(addresses instanceof Array);