feat: create metadata entries generator #272
Conversation
|
Blocking this until #275 is merged. |
araujogui
force-pushed
the
refactor-parsers
branch
from
f6ba0c8 to
37a572d
Compare
|
@araujogui I saw there is a blocked label, could you elaborate what's blocked? |
The current linter relies on metadata entries, which are no longer easily available because it's now a generator. I’ve blocked this until #275 is merged, as it removes the linter's dependency on metadata. |
araujogui
force-pushed
the
refactor-parsers
branch
from
37a572d to
2f6cf99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 63 63
Lines 4767 4767
Branches 191 191
=======================================
Hits 4318 4318
Misses 446 446
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nodejs/web-infra this is ready for reviews |
canerakdas
left a comment
canerakdas
left a comment
There was a problem hiding this comment.
just small nits for the making consistent on the type definitions, LGTM!
araujogui
force-pushed
the
refactor-parsers
branch
from
400912c to
a81d6d6
Compare
| description: 'Generates the legacy version of the JSON API docs.', | ||
|
|
||
| dependsOn: 'ast', | ||
| dependsOn: 'metadata', |
There was a problem hiding this comment.
Why are we renaming this to metadata just OOC?
5 participants
Description
Creates metadata entries generator
Related Issues
Fixes #271
Check List
node --run testand all tests passed.node --run format&node --run lint.