-
-
Notifications
You must be signed in to change notification settings - Fork 231
fix: Revert to readlink in generatePosixLink to avoid unnecessary unlinks #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+55
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Nov 10, 2025
aduh95
reviewed
Nov 10, 2025
aduh95
reviewed
Nov 10, 2025
1f32f6c to
b664e26
Compare
aduh95
reviewed
Nov 10, 2025
aduh95
reviewed
Nov 10, 2025
aduh95
reviewed
Nov 10, 2025
- add expected stdout & stderr - use Node.js async setTimeout - add --install-directory option
aduh95
reviewed
Nov 14, 2025
aduh95
reviewed
Nov 14, 2025
aduh95
approved these changes
Nov 14, 2025
Contributor
Author
|
@aduh95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Background
While running
corepack enablewithoutsudoin a CircleCI docker environment(cimg/node:22.20.0), the build failed with an EACCES: permission denied, unlink '/usr/local/bin/pnpm' error.This error was caused by the recent change #761 from readlink to realpath in generatePosixLink.
https://github.com/nodejs/corepack/pull/761/files#diff-c91b034b85c9610409bf66de5d28560a06f1285ee1962f238fac2c3652a15e88L86-R88
Problem
Using fs.promises.realpath in generatePosixLink returns the fully resolved, absolute path of the symlink target.
However, the symlink variable used in the comparison is a relative path calculated by path.relative. This results in a comparison between an absolute path and a relative path, causing the currentSymlink !== symlink check to always evaluate to true.
corepack/sources/commands/Enable.ts
Lines 83 to 98 in cf0ddc1