Fix banner loading error handling and web config constants

Author: cursoragent

src/generators/web/constants.mjs

@@ -2,6 +2,7 @@ import { resolve, dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
 export const ROOT = dirname(fileURLToPath(import.meta.url));
+export const DEFAULT_REMOTE_CONFIG_URL = 'https://nodejs.org/site.json';
 
 /**
  * @typedef {Object} JSXImportConfig

src/generators/web/index.mjs

@@ -2,6 +2,7 @@
 
 import { join } from 'node:path';
 
+import { DEFAULT_REMOTE_CONFIG_URL } from './constants.mjs';
 import { GITHUB_EDIT_URL } from '../../utils/configuration/templates.mjs';
 import { createLazyGenerator } from '../../utils/generators.mjs';
 
@@ -33,7 +34,7 @@ export default createLazyGenerator({
     title: '{project} v{version} Documentation',
     editURL: `${GITHUB_EDIT_URL}/doc/api{path}.md`,
     pageURL: '{baseURL}/latest-{version}/api{path}.html',
-    remoteConfig: 'https://nodejs.org/site.json',
+    remoteConfig: DEFAULT_REMOTE_CONFIG_URL,
     imports: {
       '#theme/Logo': '@node-core/ui-components/Common/NodejsLogo',
       '#theme/Navigation': join(import.meta.dirname, './ui/components/NavBar'),

src/generators/web/ui/components/AnnouncementBanner/__tests__/loadBanners.test.mjs

@@ -26,8 +26,9 @@ describe('loadBanners', () => {
     });
 
     it('returns an empty array on non-ok response', async t => {
+      const banner = { text: 'Global banner', type: 'warning' };
       t.mock.method(global, 'fetch', () =>
-        Promise.resolve(makeResponse({}, false))
+        Promise.resolve(makeResponse({ index: banner }, false))
       );
 
       const result = await loadBanners('https://example.com/site.json', null);

src/generators/web/ui/components/AnnouncementBanner/loadBanners.mjs

@@ -7,7 +7,7 @@ import { isBannerActive } from '../../utils/banner.mjs';
  *
  * @param {string | undefined} remoteConfig
  * @param {number | null} versionMajor
- * @returns {Promise<import('./types.d.ts').BannerEntry[]>}
+ * @returns {Promise<Array<import('./types.d.ts').BannerEntry>>}
  */
 export const loadBanners = async (remoteConfig, versionMajor) => {
   if (!remoteConfig) {
@@ -16,6 +16,9 @@ export const loadBanners = async (remoteConfig, versionMajor) => {
 
   try {
     const res = await fetch(remoteConfig);
+    if (!res.ok) {
+      return [];
+    }
 
     /** @type {import('./types.d.ts').RemoteConfig} */
     const { websiteBanners = {} } = await res.json();