Unify shell scirpts indentation style

[PeterDaveHello]

Tabs and spaces are mixed among different scripts, it's a bad smell, I personally prefer to use spaces, 2 or 4, but no tabs. Would like to discuss the solution and add tests on CI for it.

[SimenB]

Can shellcheck yell at us for it?

Sticking in an .editorconfig might be enough if people's editors respect it

[PeterDaveHello]

ShellCheck won't yell at indentation, I'd like to use some EditorConfigs tools with .editorconfig file to check it, also, GitHub supports it! Just need to confirm the style we would choose ;)

[SimenB]

Google says 2 space indent, I'm all for it.

https://google.github.io/styleguide/shell.xml?showone=Indentation#Indentation

[PeterDaveHello]

2 spaces +1

[SimenB]

https://github.com/mvdan/sh has shfmt we could use?

[chorrell]

+1 for standardizing on 2 spaces. It's a style thing I'v been wanting to address for awhile now

[PeterDaveHello]

If there is no other opinion in the next 12 hours, I'll reformat all the scripts to use 2 spaces in a PR.
Will take a look at shfmt ;)

[LaurentGoderre]

2 spaces works for me too but we need an editorconfig. I switch between projects with tabs and spaces all the time so it might have been my editors settings that introduced the mismatch

[PeterDaveHello]

I'll write one. Also add it on CI testing.