-
Notifications
You must be signed in to change notification settings - Fork 2k
Simplify the management of alpine version #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the management of alpine version #745
Conversation
01ec3b2 to
bf2f4a5
Compare
bf2f4a5 to
af31d33
Compare
|
Just needs a rebase to resolve the conflict. |
af31d33 to
94bd6f4
Compare
|
Ok, rebased! |
|
I suggest to clarify we're going to use single Alpine base image in the commit message. |
|
@PeterDaveHello that's already what we are doing so this is not changing. |
|
I know, just a suggestion that we can make the commit message more clear, not a request to change review ;) |
94bd6f4 to
06ff472
Compare
|
Done! |
|
Conflicts need to be solved. |
06ff472 to
da1ba4d
Compare
Standardizes the alpine version to use and helps upgrade the alpine version only on version update
da1ba4d to
9bd00c4
Compare
|
Done! |
|
there's something wrong with the updates script: [christopher:~/github/docker-node] master ± ./update.sh 10
Updating version 10...
sed: 1: "10/alpine/Dockerfile": invalid command code /
Done!Also, it's creating a bunch of new files: [christopher:~/github/docker-node] master(+9/-9)* ± git status
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: 10/Dockerfile
modified: 10/alpine/Dockerfile
modified: 10/slim/Dockerfile
modified: 10/stretch/Dockerfile
Untracked files:
(use "git add <file>..." to include in what will be committed)
10/Dockerfile-e
10/alpine/Dockerfile-e
10/slim/Dockerfile-e
10/stretch/Dockerfile-e
no changes added to commit (use "git add" and/or "git commit -a") |
|
And it's messing up the alpine Dockerfile for v10; [christopher:~/github/docker-node] master(+9/-9)* ± cat 10/alpine/Dockerfile | grep alpine
FROM alpine:0.0 |
|
@chorrell you're running it on a Mac aren't you?? |
|
Yes. |
|
I have gnu-sed on my mac but it's possible that the new sed commands don't work in POSIX |
Salvages parts of #725