Shush curl #749
Merged
Shush curl #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Weird, it's like the build is stuck. |
added 3 commits
May 18, 2018 13:23
Curl will fail silently with error 22 rather outputting the html error document
Member
|
It's not stuck...we just have too many build queued |
Contributor
Author
|
Yeesh |
Contributor
Author
|
The build is all green: https://travis-ci.org/nodejs/docker-node/builds/380797412 OK if I merge? |
Member
|
Merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes curl less verbose by adding the
-sflag (while still preserving errors). Previously curl would output the progress meter which wasn't really necessary. This PR also ensures we always use the-fand--compressedflags.These changes might help a little bit with travis-ci build times and also adds some consistency to how we use curl.