Update for Node.js v10.2.0 #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes Yarn update for 1.7.0
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
All green: https://travis-ci.org/nodejs/docker-node/builds/382946718 merging! |
Contributor
Author
|
Hmm, problem with the deploy stage: https://travis-ci.org/nodejs/docker-node/jobs/382969501 I'll do the docker hub PR if you can look into that above |
Contributor
Author
|
Ah, I see the issue: https://github.com/nodejs/docker-node/blob/master/generate-stackbrew-pr.sh#L121 This: echo "${stackbrew}" >"{$IMAGES_FILE}"Should be this echo "${stackbrew}" >"${IMAGES_FILE}" |
Contributor
Author
|
Docker hub PR: docker-library/official-images#4388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Yarn update for 1.7.0