Skip to content

feat: Allow all completion callback to be pausable. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

feat: Allow all completion callback to be pausable. #178

merged 2 commits into from
Aug 23, 2022

Conversation

@ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Aug 23, 2022

This PR add pausing support for:

  • on_url_complete
  • on_status_complete
  • on_header_field_complete
  • on_header_value_complete

Fixes #98.

mcollina
mcollina approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda merged commit 7b292f2 into nodejs:main Aug 23, 2022
@ShogunPanda ShogunPanda deleted the pausable-callbacks branch August 23, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@indutny indutny Awaiting requested review from indutny

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to interrupt llhttp_execute() in events like 'on_url_complete' ?

2 participants

@ShogunPanda @mcollina