feat: Added support for RTSP and ICE response and the on_protocol_complete callback. #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Aug 27, 2024
Uzlopak
reviewed
Aug 27, 2024
Contributor
|
As we are currently all here, can someone please give me permissions for llparse? it seems like it is not assigned to the group llhttp or the llhttp group does not have maintainer rights for llparse. |
Uzlopak
reviewed
Aug 27, 2024
Contributor
|
I checked the generated code and I think there should be no significant perf issues. |
Uzlopak
approved these changes
Aug 27, 2024
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
LGTM, but unfortunately no RTSP and ICE tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464.