Skip to content

fix: use correct memory address to override #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: use correct memory address to override #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ba71aa
fix: use correct memory address to override
RafaelGSS Jun 18, 2024
dc821f4
fix: consider h1report data on getSummary
RafaelGSS Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/security-release/security-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ export async function getSupportedVersions() {
}

export function getSummary(report) {
const { data } = report;
const summaryList = data?.relationships?.summaries?.data;
const summaryList = report?.relationships?.summaries?.data;
if (!summaryList?.length) return;
const summaries = summaryList.filter((summary) => summary?.attributes?.category === 'team');
if (!summaries?.length) return;
Expand Down
4 changes: 2 additions & 2 deletions lib/update_security_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class UpdateSecurityRelease {
});
const req = new Request(credentials);
for (let i = 0; i < content.reports.length; ++i) {
let report = content.reports[i];
const report = content.reports[i];
const { data } = await req.getReport(report.id);
const reportSeverity = getReportSeverity(data);
const summaryContent = getSummary(data);
Expand All @@ -42,7 +42,7 @@ export default class UpdateSecurityRelease {
prURL = data.relationships.custom_field_values.data[0].attributes.value;
}

report = {
content.reports[i] = {
...report,
title: data.attributes.title,
cveIds: data.attributes.cve_ids,
Expand Down