Skip to content

fix: remove post-release checks #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2024
Merged

fix: remove post-release checks #826

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
608a235
fix: remove post-release checks
RafaelGSS Jun 24, 2024
39814c2
fixup! fix: remove post-release checks
RafaelGSS Jun 25, 2024
9aba949
fixup! fixup! fix: remove post-release checks
RafaelGSS Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 10 additions & 31 deletions lib/security_blog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
checkoutOnSecurityReleaseBranch,
NEXT_SECURITY_RELEASE_REPOSITORY,
validateDate,
getSummary,
commitAndPushVulnerabilitiesJSON,
NEXT_SECURITY_RELEASE_FOLDER
} from './security-release/security-release.js';
Expand Down Expand Up @@ -84,6 +83,7 @@ export default class SecurityBlog {
const releaseDate = new Date(content.releaseDate);
const template = this.getSecurityPostReleaseTemplate();
const data = {
// TODO: read from pre-sec-release
annoucementDate: await this.getAnnouncementDate(cli),
releaseDate: this.formatReleaseDate(releaseDate),
affectedVersions: this.getAffectedVersions(content),
Expand Down Expand Up @@ -205,46 +205,25 @@ export default class SecurityBlog {
const reports = content.reports;
let template = '';
for (const report of reports) {
let cveId = report.cve_ids?.join(', ');
const cveId = report.cveIds?.join(', ');
if (!cveId) {
// ask for the CVE ID
// it should have been created with the step `--request-cve`
cveId = await this.cli.prompt(`What is the CVE ID for vulnerability https://hackerone.com/reports/${report.id} ${report.title}?`, {
questionType: 'input',
defaultAnswer: 'TBD'
});
report.cve_ids = [cveId];
content[kChanged] = true;
this.cli.error(`CVE ID for vulnerability ${report.link} ${report.title} not found`);
process.exit(1);
}
template += `## ${report.title} (${cveId}) - (${report.severity.rating})\n\n`;
if (!report.summary) {
const fetchIt = await this.cli.prompt(`Summary missing for vulnerability https://hackerone.com/reports/${report.id} ${report.title}.\
Do you want to try fetch it from HackerOne??`, {
questionType: 'confirm',
defaultAnswer: true
});

if (fetchIt) {
report.summary = await getSummary(report.id, this.req);
content[kChanged] = true;
}

if (!report.summary) {
this.cli.error(`Summary missing for vulnerability https://hackerone.com/reports/${report.id} ${report.title}. Please create it before continuing.`);
process.exit(1);
}
this.cli.error(`Summary missing for vulnerability ${report.link} ` +
`${report.title}. Please create it before continuing.`);
process.exit(1);
}

template += `${report.summary}\n\n`;
const releaseLines = report.affectedVersions.join(', ');
template += `Impact:\n\n- This vulnerability affects all users\
in active release lines: ${releaseLines}\n\n`;
if (!report.patchAuthors) {
const author = await this.cli.prompt(`Who fixed vulnerability https://hackerone.com/reports/${report.id} ${report.title}? If multiple use & as separator`, {
questionType: 'input',
defaultAnswer: 'TBD'
});
report.patchAuthors = author.split('&').map((p) => p.trim());
content[kChanged] = true;
this.cli.error(`Missing patch author for vulnerability ${report.link} ${report.title}`);
process.exit(1);
}
template += `Thank you, to ${report.reporter} for reporting this vulnerability\
and thank you ${report.patchAuthors.join(' and ')} for fixing it.\n\n`;
Expand Down