Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Conversation

@csosborn
Copy link

@csosborn csosborn commented Jun 7, 2011

Support for authenticating TLS connections via pre-shared keys.
RFC 4279: http://www.ietf.org/rfc/rfc4279.txt

discussion at http://groups.google.com/group/nodejs-dev/browse_thread/thread/cc28b23d8154131b

Support for authenticating TLS connections via pre-shared keys.
RFC 4279: http://www.ietf.org/rfc/rfc4279.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement seems moderately misleading considering node.js does support client certificates? I understand what is trying to be stated, maybe it just needs a different wording about the most common use cases.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I was trying to note that in the vast majority of deployments TLS doesn't authenticate the client, but of course it could. I'll amend this.

(btw, sorry for the delay in responding. I was away for several days.)

@csosborn
Copy link
Author

I noticed that more recent changes to tls.js and other files have made this patch difficult to apply. If I create a new pull request with similar changes made against the latest master will it stand a better chance of landing?

@bnoordhuis
Copy link
Member

Closing, the PR no longer applies.

@bnoordhuis bnoordhuis closed this Aug 13, 2012
@stephank stephank mentioned this pull request May 11, 2016
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants