This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Zero-copy buffers for binding external libraries #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of these changes is to add a zero-copy interface to Buffer, for binding external libraries that do their own allocation. An example of such a library is ØMQ.
The addition is an alternate public constructor
Buffer::New, that takes adatapointer andcallbackto call once the buffer is done with said data. The optionalhintparameter is simply passed verbatim to the callback, for its own use.Besides that, I've also gathered a small number of other Buffer-related changes here:
*PixelDatacalls with*ArrayDatacalls, to be consistent everywhere.copymethod, which can now target any ArrayData-like object.Tests pass with flying colors.