Skip to content

Commit 4ba536a

Browse files
committed
lib: add TLSSocket default error handler
This prevents the server from crashing due to an unhandled rejection when a TLSSocket connection is abruptly destroyed during initialization and the user has not attached an error handler to the socket. e.g: ```js const server = http2.createSecureServer({ ... }) server.on('secureConnection', socket => { socket.on('error', err => { console.log(err) }) }) ``` PR-URL: nodejs-private/node-private#797 Fixes: #44751 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=3262404 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> CVE-ID: CVE-2025-59465
1 parent 20591b0 commit 4ba536a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/_tls_wrap.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,6 +1269,7 @@ function tlsConnectionListener(rawSocket) {
12691269
socket[kErrorEmitted] = false;
12701270
socket.on('close', onSocketClose);
12711271
socket.on('_tlsError', onSocketTLSError);
1272+
socket.on('error', onSocketTLSError);
12721273
}
12731274

12741275
// AUTHENTICATION MODES

0 commit comments

Comments
 (0)