deps: V8: backport 0a8b1cdcc8b2

Original commit message:

    implement rapidhash secret generation

    Bug: 409717082
    Change-Id: I471f33d66de32002f744aeba534c1d34f71e27d2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6733490
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: snek <snek@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101499}

Refs: v8/v8@0a8b1cd
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs-private/node-private#828

Author: 2 people

common.gypi

@@ -38,7 +38,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.41',
+    'v8_embedder_string': '-node.42',
 
     ##### V8 defaults for Node.js #####
 

deps/v8/.gitignore

@@ -89,6 +89,7 @@
 /third_party/jsoncpp/source
 !/third_party/llvm-libc
 /third_party/llvm-libc/src
+!/third_party/rapidhash-v8
 !/third_party/re2
 /third_party/re2/src
 !/third_party/siphash

deps/v8/BUILD.bazel

@@ -1936,6 +1936,7 @@ filegroup(
         "src/numbers/conversions.cc",
         "src/numbers/conversions.h",
         "src/numbers/conversions-inl.h",
+        "src/numbers/hash-seed.h",
         "src/numbers/hash-seed-inl.h",
         "src/numbers/ieee754.cc",
         "src/numbers/ieee754.h",
@@ -2560,6 +2561,8 @@ filegroup(
         "src/zone/zone-segment.h",
         "src/zone/zone-type-traits.h",
         "src/zone/zone-utils.h",
+        "third_party/rapidhash-v8/rapidhash.h",
+        "third_party/rapidhash-v8/secret.h",
         "third_party/siphash/halfsiphash.cc",
         "third_party/siphash/halfsiphash.h",
         "third_party/utf8-decoder/utf8-decoder.h",

deps/v8/BUILD.gn

@@ -515,6 +515,9 @@ declare_args() {
 
   # Deinterleaving load support.
   v8_enable_wasm_deinterleaved_mem_ops = false
+
+  # Use a hard-coded secret value when hashing.
+  v8_use_default_hasher_secret = true
 }
 
 # Derived defaults.
@@ -977,6 +980,7 @@ external_v8_defines = [
   "V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT=${v8_array_buffer_internal_field_count}",
   "V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT=${v8_array_buffer_view_internal_field_count}",
   "V8_PROMISE_INTERNAL_FIELD_COUNT=${v8_promise_internal_field_count}",
+  "V8_USE_DEFAULT_HASHER_SECRET=${v8_use_default_hasher_secret}",
   "V8_ENABLE_CHECKS",
   "V8_ENABLE_MEMORY_ACCOUNTING_CHECKS",
   "V8_COMPRESS_POINTERS",
@@ -1006,6 +1010,7 @@ enabled_external_v8_defines = [
   "V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT=${v8_array_buffer_internal_field_count}",
   "V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT=${v8_array_buffer_view_internal_field_count}",
   "V8_PROMISE_INTERNAL_FIELD_COUNT=${v8_promise_internal_field_count}",
+  "V8_USE_DEFAULT_HASHER_SECRET=${v8_use_default_hasher_secret}",
 ]
 
 if (v8_enable_v8_checks) {
@@ -2879,6 +2884,7 @@ generated_file("v8_generate_features_json") {
     v8_random_seed = v8_random_seed
     v8_use_perfetto = v8_use_perfetto
     v8_use_siphash = v8_use_siphash
+    v8_use_default_hasher_secret = v8_use_default_hasher_secret
   }
 }
 
@@ -3910,6 +3916,7 @@ v8_header_set("v8_internal_headers") {
     "src/numbers/conversions-inl.h",
     "src/numbers/conversions.h",
     "src/numbers/hash-seed-inl.h",
+    "src/numbers/hash-seed.h",
     "src/numbers/ieee754.h",
     "src/numbers/math-random.h",
     "src/objects/all-objects-inl.h",
@@ -4280,6 +4287,7 @@ v8_header_set("v8_internal_headers") {
     "src/tasks/operations-barrier.h",
     "src/tasks/task-utils.h",
     "src/temporal/temporal-parser.h",
+    "third_party/rapidhash-v8/rapidhash.h",
     "src/torque/runtime-macro-shims.h",
     "src/tracing/trace-event-no-perfetto.h",
     "src/tracing/trace-event.h",
@@ -4318,6 +4326,7 @@ v8_header_set("v8_internal_headers") {
     "src/zone/zone-type-traits.h",
     "src/zone/zone-utils.h",
     "src/zone/zone.h",
+    "third_party/rapidhash-v8/secret.h",
     "third_party/siphash/halfsiphash.h",
     "third_party/utf8-decoder/utf8-decoder.h",
   ]

deps/v8/src/DEPS

@@ -129,4 +129,13 @@ specific_include_rules = {
   "snapshot\.cc": [
     "+src/heap/read-only-promotion.h",
   ],
+  "string-hasher-inl\.h": [
+    "+third_party/rapidhash-v8/rapidhash.h",
+  ],
+  "heap\.cc": [
+    "+third_party/rapidhash-v8/secret.h",
+  ],
+  "hash-seed-inl\.h": [
+    "+third_party/rapidhash-v8/secret.h",
+  ],
 }

deps/v8/src/api/api.cc

@@ -10980,7 +10980,7 @@ std::string Isolate::GetDefaultLocale() {
 
 uint64_t Isolate::GetHashSeed() {
   i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this);
-  return HashSeed(i_isolate);
+  return i::HashSeed(i_isolate).seed();
 }
 
 #if defined(V8_ENABLE_ETW_STACK_WALKING)

deps/v8/src/ast/ast-value-factory.cc

@@ -292,7 +292,8 @@ std::forward_list<const AstRawString*> AstConsString::ToRawStrings() const {
   return result;
 }
 
-AstStringConstants::AstStringConstants(Isolate* isolate, uint64_t hash_seed)
+AstStringConstants::AstStringConstants(Isolate* isolate,
+                                       const HashSeed hash_seed)
     : zone_(isolate->allocator(), ZONE_NAME),
       string_table_(),
       hash_seed_(hash_seed) {

deps/v8/src/ast/ast-value-factory.h

@@ -35,6 +35,7 @@
 #include "src/common/globals.h"
 #include "src/handles/handles.h"
 #include "src/numbers/conversions.h"
+#include "src/numbers/hash-seed.h"
 #include "src/objects/name.h"
 #include "src/zone/zone.h"
 
@@ -299,7 +300,7 @@ class AstStringConstants final {
       0 SINGLE_CHARACTER_ASCII_AST_STRING_CONSTANTS(F);
 #undef F
 
-  AstStringConstants(Isolate* isolate, uint64_t hash_seed);
+  AstStringConstants(Isolate* isolate, const HashSeed hash_seed);
   AstStringConstants(const AstStringConstants&) = delete;
   AstStringConstants& operator=(const AstStringConstants&) = delete;
 
@@ -308,7 +309,7 @@ class AstStringConstants final {
   AST_STRING_CONSTANTS(F)
 #undef F
 
-  uint64_t hash_seed() const { return hash_seed_; }
+  const HashSeed hash_seed() const { return hash_seed_; }
   const AstRawStringMap* string_table() const { return &string_table_; }
   const AstRawString* one_character_string(int c) const {
     DCHECK_GE(c, 0);
@@ -329,7 +330,7 @@ class AstStringConstants final {
  private:
   Zone zone_;
   AstRawStringMap string_table_;
-  uint64_t hash_seed_;
+  const HashSeed hash_seed_;
 
 #define F(name, str) AstRawString* name##_;
   AST_STRING_CONSTANTS(F)
@@ -339,12 +340,12 @@ class AstStringConstants final {
 class AstValueFactory {
  public:
   AstValueFactory(Zone* zone, const AstStringConstants* string_constants,
-                  uint64_t hash_seed)
+                  const HashSeed hash_seed)
       : AstValueFactory(zone, zone, string_constants, hash_seed) {}
 
   AstValueFactory(Zone* ast_raw_string_zone, Zone* single_parse_zone,
                   const AstStringConstants* string_constants,
-                  uint64_t hash_seed)
+                  const HashSeed hash_seed)
       : string_table_(string_constants->string_table()),
         strings_(nullptr),
         strings_end_(&strings_),
@@ -433,7 +434,7 @@ class AstValueFactory {
   Zone* ast_raw_string_zone_;
   Zone* single_parse_zone_;
 
-  uint64_t hash_seed_;
+  const HashSeed hash_seed_;
 };
 
 extern template EXPORT_TEMPLATE_DECLARE(

deps/v8/src/codegen/external-reference.cc

@@ -1414,7 +1414,8 @@ FUNCTION_REFERENCE(jsreceiver_create_identity_hash,
 
 static uint32_t ComputeSeededIntegerHash(Isolate* isolate, int32_t key) {
   DisallowGarbageCollection no_gc;
-  return ComputeSeededHash(static_cast<uint32_t>(key), HashSeed(isolate));
+  return ComputeSeededHash(static_cast<uint32_t>(key),
+                           HashSeed(isolate).seed());
 }
 
 FUNCTION_REFERENCE(compute_integer_hash, ComputeSeededIntegerHash)

deps/v8/src/debug/debug-interface.cc

@@ -915,7 +915,8 @@ uint32_t WasmScript::GetFunctionHash(int function_index) {
       wire_bytes.GetFunctionBytes(&func);
   // TODO(herhut): Maybe also take module, name and signature into account.
   return i::StringHasher::HashSequentialString(function_bytes.begin(),
-                                               function_bytes.length(), 0);
+                                               function_bytes.length(),
+                                               internal::HashSeed::Default());
 }
 
 Maybe<v8::MemorySpan<const uint8_t>> WasmScript::GetModuleBuildId() const {