Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Backport-PR-URL info in backport guide #23701

Closed
wants to merge 1 commit into from

Conversation

@ofrobots
Copy link
Contributor

commented Oct 16, 2018

This feedback was raised in #23398 (comment). /cc @targos.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@targos
targos approved these changes Oct 16, 2018
Copy link
Member

left a comment

Thanks. I was certain it was already documented somewhere

@mmarchini
Copy link
Member

left a comment

Does git node metadata/git node land add Backport-PR-URL to commits?

@mhdawson
Copy link
Member

left a comment

LGTM

@targos

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@mmarchini No, they do not support landing backport pull requests.

@refack
refack approved these changes Oct 16, 2018
@joyeecheung

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

No, they do not support landing backport pull requests.

Refs: nodejs/node-core-utils#194

(Feeling guilty that this is a 7-month-year-old feature request but PRs are welcomed!)

@lpinca
lpinca approved these changes Oct 17, 2018

@ofrobots ofrobots force-pushed the ofrobots-patch-1 branch from 4993d4f to cd574c3 Oct 17, 2018

@ofrobots

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

It's a total nit, but the commit linter is complaining because the first word after the subsystem is not a lowercase verb. Maybe this for the title line?

doc: add Backport-PR-URL info in backport guide

@ofrobots ofrobots force-pushed the ofrobots-patch-1 branch from cd574c3 to d3233c4 Oct 19, 2018

@ofrobots ofrobots changed the title doc: Backport-PR-URL info in backport guide doc: add Backport-PR-URL info in backport guide Oct 19, 2018

@gdams
gdams approved these changes Oct 19, 2018
@AyushG3112
Copy link
Contributor

left a comment

9.1, and all points following this one are now numbered 1

@AyushG3112
Copy link
Contributor

left a comment

Fixing ordering:

@targos

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

@AyushG3112 that's probably done on purpose. It is allowed by markdown and has an advantage: you can add a new line in the middle later without changing the others

@ofrobots

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2018

Landed as 72cf81f.

@ofrobots ofrobots closed this Oct 19, 2018

@ofrobots ofrobots deleted the ofrobots-patch-1 branch Oct 19, 2018

ofrobots added a commit that referenced this pull request Oct 19, 2018
doc: add Backport-PR-URL info in backport guide
PR-URL: #23701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax added a commit that referenced this pull request Oct 20, 2018
doc: add Backport-PR-URL info in backport guide
PR-URL: #23701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Oct 21, 2018
doc: add Backport-PR-URL info in backport guide
PR-URL: #23701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 30, 2018
doc: add Backport-PR-URL info in backport guide
PR-URL: #23701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: add Backport-PR-URL info in backport guide
PR-URL: #23701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
doc: add Backport-PR-URL info in backport guide
PR-URL: #23701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.