process: check env->EmitProcessEnvWarning() last #25575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
bcoe
force-pushed
the
fix-process-warn
branch
from
f08f902
to
409d417
Compare
addaleax
approved these changes
Jan 18, 2019
joyeecheung
approved these changes
Jan 18, 2019
refack
approved these changes
Jan 19, 2019
|
Verified local that the test indeed fails without the patch: DEV D:\code\prws>node.nightly20190114.exe --pending-deprecation test/parallel/test-process-env-deprecation.js
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
at mustCall (D:\code\prws\test\common\index.js:344:10)
at _expectWarning (D:\code\prws\test\common\index.js:514:10)
at Object.expectWarning (D:\code\prws\test\common\index.js:534:31)
at Object.<anonymous> (D:\code\prws\test\parallel\test-process-env-deprecation.js:7:8)
at Module._compile (internal/modules/cjs/loader.js:722:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
at Module.load (internal/modules/cjs/loader.js:621:32)
at tryModuleLoad (internal/modules/cjs/loader.js:564:12)
at Function.Module._load (internal/modules/cjs/loader.js:556:3)
DEV D:\code\prws>"D:\code\temp\node25575.exe" --pending-deprecation test/parallel/test-process-env-deprecation.js
(node:12684) [DEP0104] DeprecationWarning: Assigning any value other than a string, number, or boolean to a process.env property is deprecated. Please make sure to convert the value to a string before setting process.env with it.
DEV D:\code\prws>echo %errorlevel%
0 |
refack
added
process
cjihrig
approved these changes
Jan 19, 2019
|
any objection to fast tracking this, would like to rebase #25157 against it. |
|
IMO it's not a good fit for fast tracking. It changes code semantics in a nuanced way... |
thefourtheye
approved these changes
Jan 20, 2019
bcoe
force-pushed
the
fix-process-warn
branch
from
409d417
to
d1dee49
Compare
bcoe
force-pushed
the
fix-process-warn
branch
from
c95d9c2
to
5ab98a5
Compare
Calling env->EmitProcessEnvWarning() prevents additional warnings from being set it should therefore be called only if a warning will emit.
|
Landed in 0b50972 |
bcoe
added a commit
that referenced
this pull request
Jan 21, 2019
Calling env->EmitProcessEnvWarning() prevents additional warnings from being set it should therefore be called only if a warning will emit. PR-URL: #25575 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
Calling env->EmitProcessEnvWarning() prevents additional warnings from being set it should therefore be called only if a warning will emit. PR-URL: #25575 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling env->EmitProcessEnvWarning() prevents additional warnings from being set
it should therefore be called only if a warning will emit.
Split this work out from #25157, addressing @joyeecheung's concerns.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes