build: enable NODE_DEBUG=test by default for tests #32696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By convention, `require('util').debuglog('test')` can be used
within tests to separate debug output from console.log/error
statements that are actually a part of the test. These should
be enabled by default in most cases in CI.
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
build
11 tasks
addaleax
requested changes
Apr 6, 2020
There was a problem hiding this comment.
Running tests locally and running them in CI should match as closely as possible for a good DX, otherwise we are bound to run into situations in which tests fail locally and pass in CI or vice versa a lot more often.
I’d either not do this, or enable it for all test situations (preferably from the test runner in that case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By convention,
require('util').debuglog('test')can be usedwithin tests to separate debug output from console.log/error
statements that are actually a part of the test. These should
be enabled by default in most cases in CI.
Running
make test-cior variants (e.g.test-ci-js) will setthe
NODE_DEBUG=testoption by default unless explicitlyoverridden.
vcbuildwill setNODE_DEBUG=testautomaticallyunless the
no-debug-testoption is set.Refs: #32678
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes