Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] cli: add --watch #44571

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] cli: add --watch #44571

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 8, 2022 •
edited
Loading

backport of #44366 with a fix for tests to skip --import

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/modules
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 8, 2022
@joyeecheung joyeecheung mentioned this pull request Sep 8, 2022
Closed
@aduh95
Copy link
Contributor

aduh95 commented Sep 8, 2022

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

@MoLow
Copy link
Member Author

MoLow commented Sep 8, 2022

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

done

@MoLow
Copy link
Member Author

MoLow commented Sep 11, 2022

@aduh95 what is the procedure of landing this into v18.x-staging?

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95
Copy link
Contributor

aduh95 commented Sep 11, 2022

@aduh95 what is the procedure of landing this into v18.x-staging?

I know the rule for LTS is to leave it to the appropriate team:

node/doc/contributing/collaborator-guide.md

Lines 768 to 769 in 3ec8876

Only members of @nodejs/backporters should land commits onto LTS staging
branches.

As v18.x is not (yet) LTS, the rule might be different, but I would leave it up to @nodejs/releasers to leave them full control over the release process.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46518/

This was referenced Sep 12, 2022
Open
Open
Open
Open
RafaelGSS
RafaelGSS reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoLow can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

@aduh95
Copy link
Contributor

aduh95 commented Sep 15, 2022

can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

@RafaelGSS isn't that done by ncu upon landing?

@MoLow
cli: add --watch
3a6c65b 
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44571
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
Copy link
Member Author

MoLow commented Sep 15, 2022

@RafaelGSS added metadata and squashed - as discussed in slack

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46611/

@github-actions github-actions bot mentioned this pull request Sep 16, 2022
Open
23 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46618/

RafaelGSS
RafaelGSS approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was referenced Sep 17, 2022
Open
Open
Open
Open
@RafaelGSS
Copy link
Member

Landed in 4700ee5

@RafaelGSS RafaelGSS closed this Sep 23, 2022
RafaelGSS pushed a commit that referenced this pull request Sep 23, 2022
@MoLow @RafaelGSS
cli: add --watch
4700ee5 
PR-URL: #44366
Backport-PR-URL: #44571
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 26, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@MoLow @RafaelGSS
cli: add --watch
3b0957e 
PR-URL: #44366
Backport-PR-URL: #44571
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSS RafaelGSS reopened this Sep 27, 2022
@RafaelGSS
Copy link
Member

It didn't land cleanly on the proposal branch. Can you please rebase and run the CI again? See #44799 (comment)

@MoLow
Copy link
Member Author

MoLow commented Sep 29, 2022

@RafaelGSS the cause was a merge mess up resulting with both test/parallel/test-watch-mode.mjs and test/sequential/test-watch-mode.mjs in nodejs:v18.x-staging when only one should have existed. I will create a new backport PR with all the relevant commits in a single PR

@MoLow MoLow closed this Sep 29, 2022
@MoLow MoLow deleted the backport-watch-mode branch September 29, 2022 08:38
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoLow @nodejs-github-bot @aduh95 @RafaelGSS @JungMinu