-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: update comment in CODEOWNERS
to better reflect current policy
#45944
meta: update comment in CODEOWNERS
to better reflect current policy
#45944
Conversation
We do not enforce signing off by any code owners when landing PRs.
Review requested:
|
Rather than restate the policy from the collaborator guide, perhaps this comment should just link to it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree with @GeoffreyBooth, doc/contributing/collaborator-guide.md
is a much better place for this info because all collaborators are familiar with it. I don't think many collaborators will look at comments in a GitHub specific file for our policies.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
I've added a few additional changes which after giving it a few thoughts, I think should belong in this PR:
PTAL if you already approved the PR, and consider re-approving if you agree with that new change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 6f50acd |
We do not enforce signing off by any code owners when landing PRs. PR-URL: nodejs#45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
We do not enforce signing off by any code owners when landing PRs. PR-URL: #45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
We do not enforce signing off by any code owners when landing PRs. PR-URL: #45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
We do not enforce signing off by any code owners when landing PRs. PR-URL: #45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
We do not enforce signing off by any code owners when landing PRs.
We may want to take the opportunity to refine our policy regarding CODEOWNERS and what are the criteria to consider a PR ready to land. Currently, here are the criteria listed in the Collaborator Guide:
node/doc/contributing/collaborator-guide.md
Lines 139 to 147 in 6831e2f
node/doc/contributing/collaborator-guide.md
Lines 122 to 129 in 6831e2f
/cc @GeoffreyBooth @nodejs/tsc