Skip to content

http2: rename variable to additionalPseudoHeaders #60208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

http2: rename variable to additionalPseudoHeaders #60208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/internal/http2/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ function prepareRequestHeadersArray(headers, session) {
let path;
let protocol;

// Extract the key psuedo header values from the headers array
// Extract the key pseudo header values from the headers array.
for (let i = 0; i < headers.length; i += 2) {
if (headers[i][0] !== ':') {
continue;
Expand All @@ -648,26 +648,26 @@ function prepareRequestHeadersArray(headers, session) {

// We then build an array of any missing pseudo headers, to prepend
// default values to the given header array:
const additionalPsuedoHeaders = [];
const additionalPseudoHeaders = [];

if (method === undefined) {
method = HTTP2_METHOD_GET;
additionalPsuedoHeaders.push(HTTP2_HEADER_METHOD, method);
additionalPseudoHeaders.push(HTTP2_HEADER_METHOD, method);
}

const connect = method === HTTP2_METHOD_CONNECT;

if (!connect || protocol !== undefined) {
if (authority === undefined && headers[HTTP2_HEADER_HOST] === undefined) {
authority = session[kAuthority];
additionalPsuedoHeaders.push(HTTP2_HEADER_AUTHORITY, authority);
additionalPseudoHeaders.push(HTTP2_HEADER_AUTHORITY, authority);
}
if (scheme === undefined) {
scheme = session[kProtocol].slice(0, -1);
additionalPsuedoHeaders.push(HTTP2_HEADER_SCHEME, scheme);
additionalPseudoHeaders.push(HTTP2_HEADER_SCHEME, scheme);
}
if (path === undefined) {
additionalPsuedoHeaders.push(HTTP2_HEADER_PATH, '/');
additionalPseudoHeaders.push(HTTP2_HEADER_PATH, '/');
}
} else {
if (authority === undefined)
Expand All @@ -679,8 +679,8 @@ function prepareRequestHeadersArray(headers, session) {
}

const rawHeaders =
additionalPsuedoHeaders.length ?
additionalPsuedoHeaders.concat(headers) :
additionalPseudoHeaders.length ?
additionalPseudoHeaders.concat(headers) :
headers;

if (headers[kSensitiveHeaders] !== undefined) {
Expand Down
Loading