Skip to content

deps: V8: cherry-pick 72b0e27bd936432d4998e4d1762e7a8fe6d347f5 #60276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: V8: cherry-pick 72b0e27bd936432d4998e4d1762e7a8fe6d347f5 #60276

wants to merge 1 commit into from
+19 −8

Conversation

Renegade334
Copy link
Contributor

Refs: v8/v8@72b0e27
Fixes: #60030

Doesn't land on v24.x and earlier.

@Renegade334
deps: V8: cherry-pick 72b0e27bd936432d4998e4d1762e7a8fe6d347f5
67749e7 
Original commit message:

    [regexp] Fix modifiers for ChoiceNodes

    Each alternative might modify flags when their sub-graph is emitted.
    We need to restore flags to the value at the beginning of a ChoiceNode
    for each alternative.

    Drive-by: Move regexp-modifiers test out of harmony/

    Fixed: 447583670
    Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#102838}
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 16, 2025
@targos
Copy link
Member

targos commented Oct 16, 2025

Doesn't land on v24.x and earlier.

Is it backportable? If not, this won't really fix, #60030 which was reported on v24.x

@Renegade334
Copy link
Contributor Author

Renegade334 commented Oct 16, 2025 •
edited
Loading

Is it backportable?

I believe so. The unmergability stems from v8/v8@df20105, but I think the commit should still be standalone if the diffs are applied manually.

@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. labels Oct 16, 2025
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69759/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6805/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6805/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6805/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

regex Modifier syntax not working as expected

4 participants

@Renegade334 @nodejs-github-bot @targos @cjihrig