Skip to content

Conversation

@islandryu
Copy link
Member

I fixed an issue where Node.js would crash if a WebSocket client sent a non-JSON message while the Inspector was open, like in the following example:

const socket = new WebSocket('ws://127.0.0.1:9229/e9817809-7f12-450b-ae45-e1fe9be416f4');

socket.addEventListener('open', (event) => {
    socket.send('Hello Server!');
});

Sorry, this issue was due to a mistake in the implementation of the following change.
#56759

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.58%. Comparing base (2fb82c8) to head (db32729).
⚠️ Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector_io.cc 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60388      +/-   ##
==========================================
- Coverage   88.59%   88.58%   -0.02%     
==========================================
  Files         704      704              
  Lines      208474   207817     -657     
  Branches    40067    40039      -28     
==========================================
- Hits       184696   184090     -606     
+ Misses      15805    15762      -43     
+ Partials     7973     7965       -8     
Files with missing lines Coverage Δ
src/inspector_io.cc 91.80% <0.00%> (-0.76%) ⬇️

... and 132 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@islandryu islandryu marked this pull request as draft October 24, 2025 12:24
@islandryu islandryu marked this pull request as ready for review October 24, 2025 13:00
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the test skipped when inspector disabled.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants