-
-
Couldn't load subscription status.
- Fork 33.6k
inspector: fix crash when receiving non json message #60388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60388 +/- ##
==========================================
- Coverage 88.59% 88.58% -0.02%
==========================================
Files 704 704
Lines 208474 207817 -657
Branches 40067 40039 -28
==========================================
- Hits 184696 184090 -606
+ Misses 15805 15762 -43
+ Partials 7973 7965 -8
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the test skipped when inspector disabled.
I fixed an issue where Node.js would crash if a WebSocket client sent a non-JSON message while the Inspector was open, like in the following example:
Sorry, this issue was due to a mistake in the implementation of the following change.
#56759