deps: V8: cherry-pick highway@989a498fdf3 #60682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
v8 engine
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
targos
approved these changes
Nov 12, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
cjihrig
approved these changes
Nov 12, 2025
richardlau
added
author ready
lpinca
approved these changes
Nov 12, 2025
meixg
approved these changes
Nov 13, 2025
Member
Author
richardlau
removed
the
commit-queue
Member
|
@richardlau thanks, I just landed the V8 update. |
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
richardlau
force-pushed
the
backport-highway-fix-gcc15
branch
from
a10eaa3 to
5c19834
Compare
Member
Author
|
Rebased and renumbered the embedder string. |
targos
approved these changes
Nov 13, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in da71ab6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: google/highway@989a498
Fixes: #60566
cc @nodejs/v8-update
This hasn't landed in upstream V8 yet, so the usual
@node-core/utilsV8 backport tooling can't be used. I've tried to replicate the commit message format. Hopefully V8 will roll the highway dependency forward to pick up the fix so we won't have to float the patch forever.